genimage: improve tmppath handling #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now cleanup is partially broken: If the tmppath exists, then its content is removed at the end as expected. However, if the tmppath is missing then it is created but nothing is removed. Change this to remove the directory including its content at the end when the directory was created but stick to removing just the content if the directory existed before genimage was called. Fixes: pengutronix#237 Signed-off-by: Michael Olbrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now cleanup is partially broken:
If the tmppath exists, then its content is removed at the end as expected. However, if the tmppath is missing then it is created but nothing is removed.
Change this to remove the directory including its content at the end when the directory was created but stick to removing just the content if the directory existed before genimage was called.
Fixes: #237