image-hd: do not use first partition offset for GPT's first usable LBA #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently first usable LBA in the GPT header is pointing to offset of the first partition, ignoring the gpt-location specified in the config. This can lead to some issues as explained in [1]. Disabling this behavior doesn't break any tests and allows for generating of images that have same layout as those generated by sgdisk or other utilities. [1] pengutronix#262 Signed-off-by: Jan Čermák <[email protected]>
|
Superseded by #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently first usable LBA in the GPT header is pointing to offset of the first partition, ignoring the gpt-location specified in the config. This can lead to some issues as explained in [1]. Disabling this behavior doesn't break any tests and allows for generating of images that have same layout as those generated by sgdisk or other utilities.
[1] #262