Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller fixes #32

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Smaller fixes #32

merged 2 commits into from
Dec 12, 2023

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Dec 6, 2023

Two smaller enhancements. The first commit makes umpf easier to use on distributions not shipping /bin/bash, the second makes umpf show to capture a series with multiple branches more convenient.

Use /usr/bin/env to find bash instead of using the common, but not
guaranteed to exist /bin/bash.

Signed-off-by: Rouven Czerwinski <[email protected]>
Instead of using echo, which will print to stdout, use info to print to
stderr. This way branch questions can be resolved without the branch
names being written to the show output during umpf show when redirecting
into a file.

Signed-off-by: Rouven Czerwinski <[email protected]>
@Emantor Emantor added the enhancement New feature or request label Dec 6, 2023
@rohieb
Copy link
Contributor

rohieb commented Dec 12, 2023

The only thing changed by the echoinfo is that the message gets shown on stderr, so you probably mean that you want to pipe the output of umpf show into somewhere and don't want the prompt to end up in it too?

@Emantor
Copy link
Member Author

Emantor commented Dec 12, 2023

Exactly 👍

@Emantor Emantor merged commit 62662f3 into pengutronix:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants