Pcp schedule sharing - frontend+backend #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nn-courses into pcp-schedule-sharing
andyjiang3
changed the title
andyjiang3
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Nice work! Thanks for also refactoring / removing locally storing schedule data - left some comments on refactoring and naming for code readability. Besides from that, we just need to:
- Throughly test schedule sharing - approving requests doesn't seem to be working for me locally (giving me 409 error).
- Viewing friends schedule: no courses added to their schedule, not sharing a schedule
- Loading friends schedule
- Test schedule / cart changes syncing with backend - ex. add courses to cart, log out, and make sure its up-to-date after logging in, edge cases: cart, semester, new acc (cart, "Schedule")??
- @mialana can you add a few sentence to the PR describing the changes to backend-frontend syncing / locally storing some schedule data on the frontend for future reference?
|
|
||
| interface AddScheduleFriendsModalInteriorProps { | ||
| user: User; | ||
| existingData: string[] | User[]; |
There was a problem hiding this comment.
Can we add a Friends type, defined as User[]
| // hash every section to a color, but if that color is taken, try the next color in the | ||
| // colors array. Only start reusing colors when all the colors are used. | ||
| const getColor = (() => { | ||
| const colors = [ |
| delete newSchedule.id; | ||
| return newSchedule; | ||
| readOnly: false, | ||
| primaryScheduleId: "-1", |
There was a problem hiding this comment.
is there a reason why primaryScheduleId is a string?
| newState.deletedSchedules.reduce( | ||
| (acc, schedule) => acc || schedule === scheduleFromBackend.name, | ||
| false | ||
| ) |
| foundSchedule.pushedToBackend && | ||
| cloudUpdated >= foundSchedule.updated_at && | ||
| foundSchedule.updated_at - cloudUpdated >= | ||
| MIN_TIME_DIFFERENCE) |
There was a problem hiding this comment.
foundSchedule.updated_at - cloudUpdated would always be negative and thus this if statement would always be false?
andyjiang3
reviewed
Sep 17, 2023
|
TODO: @anshnagwekar @andyjiang3 remove reverse_func in doc_settings and potentially other places |
|
Primary updates:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.