Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iscimport script to handle banner semesters (e.g., '202310') #515

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

AaDalal
Copy link
Contributor

@AaDalal AaDalal commented Sep 27, 2023

No description provided.

@AaDalal AaDalal self-assigned this Sep 27, 2023
@AaDalal AaDalal requested a review from mureytasroc September 27, 2023 02:36
@AaDalal
Copy link
Contributor Author

AaDalal commented Sep 27, 2023

@mureytasroc side note, but I think we should re-write this script at some point because it's a little hard to read/maintain RN.

Copy link
Contributor

@mureytasroc mureytasroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gitguardian
Copy link

gitguardian bot commented Oct 14, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@AaDalal AaDalal force-pushed the aagam/update-iscimport branch 2 times, most recently from 4f9fd62 to a4048c5 Compare October 14, 2023 18:23
@AaDalal AaDalal merged commit f22d2e9 into master Oct 26, 2023
11 checks passed
@AaDalal AaDalal deleted the aagam/update-iscimport branch October 26, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants