Course audit feature #520
Open
Course audit feature #520
+1,274
−1,022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaDalal
reviewed
Oct 26, 2023
backend/courses/views.py
Outdated
| """ | ||
|
|
||
| def get(self, request, semester): | ||
| timestamp = request.GET.get("timestamp") |
There was a problem hiding this comment.
Nit: DRF (Django rest framework) provides the request.query_params.get(...) which is more readable
|
Note that this contains some commits from another open PR that shouldn't be merged yet, prob should remove if we're planning on merging this before that PR |
|
Also should prob fix the pre-commit hooks so that it does the linting - seems like we all have different formatters and it makes review harder. @AaDalal (I can look into this but would have to be sometimes late next week) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some changes to the docker container environment. Please restart the development environment if things are not working.