-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKLOG-42827] - CRUD for Global objects in repository #9750
Open
abryant-hv
wants to merge
1
commit into
pentaho:project-profile
Choose a base branch
from
abryant-hv:BACKLOG-42827
base: project-profile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abryant-hv
commented
Dec 5, 2024
•
edited
Loading
edited
abryant-hv
force-pushed
the
BACKLOG-42827
branch
2 times, most recently
from
December 10, 2024 14:40
03d0317
to
538a797
Compare
abryant-hv
changed the title
[BACKLOG-42827] - RepositorySharedObjectsIO and test
[BACKLOG-42827] - CRUD for Global objects in repository
Dec 10, 2024
abryant-hv
force-pushed
the
BACKLOG-42827
branch
from
December 10, 2024 21:09
538a797
to
211a34d
Compare
pdesai16
reviewed
Dec 16, 2024
engine/src/main/java/org/pentaho/di/repository/filerep/KettleFileRepository.java
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
engine/src/main/java/org/pentaho/di/shared/RepositorySharedObjectsIO.java
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
engine/src/test/java/org/pentaho/di/shared/RepositorySharedObjectsIOTest.java
Outdated
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
engine/src/test/java/org/pentaho/di/shared/RepositorySharedObjectsIOTest.java
Outdated
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/ISharedObjectsTransformer.java
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/ISharedObjectsTransformer.java
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/JobDelegate.java
Show resolved
Hide resolved
pdesai16
reviewed
Dec 16, 2024
plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/JobDelegate.java
Show resolved
Hide resolved
- RepositorySharedObjectsIO and test - fixed file-open-save for repositories (partial backport) - stopped saving or loading shared objects to the repository as part of transformations or jobs. - Still links steps to databases - Keep ObjectId in various Node-based memory structures, but don't store on disk in VfsSharedObjectsIO - Reset DefaultBowl managers on connect/disconnect from Repository
abryant-hv
force-pushed
the
BACKLOG-42827
branch
from
December 16, 2024 20:29
211a34d
to
b81de9b
Compare
pdesai16
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.