-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS-9255 [8.0] Adding CONTRIBUTING.md file #5445
Merged
lukin-oleksiy
merged 1 commit into
percona:8.0
from
lukin-oleksiy:PS-9255-update-contributing_md
Nov 25, 2024
Merged
PS-9255 [8.0] Adding CONTRIBUTING.md file #5445
lukin-oleksiy
merged 1 commit into
percona:8.0
from
lukin-oleksiy:PS-9255-update-contributing_md
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbirch
reviewed
Oct 7, 2024
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
from
October 7, 2024 11:58
db1d2ed
to
3605816
Compare
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
patrickbirch
reviewed
Oct 7, 2024
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
2 times, most recently
from
October 16, 2024 07:52
bfadb2c
to
a67d186
Compare
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
from
October 21, 2024 10:26
a67d186
to
f878bd0
Compare
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
2 times, most recently
from
November 4, 2024 07:35
c1650fd
to
0a1ed75
Compare
hulyav
approved these changes
Nov 14, 2024
percona-ysorokin
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some scripting fixes requested.
But in general "Great Work".
Thanks a lot @lukin-oleksiy and @patrickbirch
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
from
November 22, 2024 10:44
3323234
to
69c3737
Compare
https://perconadev.atlassian.net/browse/PS-9255 Co-authored-by: Yura Sorokin <[email protected]>
lukin-oleksiy
force-pushed
the
PS-9255-update-contributing_md
branch
from
November 25, 2024 10:31
75282e1
to
5af5102
Compare
percona-ysorokin
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lukin-oleksiy
added a commit
to lukin-oleksiy/percona-server
that referenced
this pull request
Dec 2, 2024
lukin-oleksiy
changed the title
PS-9255 Adding CONTRIBUTING.md file
PS-9255 [8.0] Adding CONTRIBUTING.md file
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS-9255 Adding CONTRIBUTING.md file
https://perconadev.atlassian.net/browse/PS-9255