Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-9470 : Code refresh for PS 8.4.3 - post merge MTR fix (disabled pe… #5481

Conversation

dlenev
Copy link
Contributor

@dlenev dlenev commented Nov 8, 2024

…rcona.backup_safe_binlog_info test)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897

…rcona.backup_safe_binlog_info test)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
Copy link
Collaborator

@percona-ysorokin percona-ysorokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@percona-ysorokin percona-ysorokin merged commit a4c4553 into percona:release-8.4.3-3 Nov 11, 2024
9 checks passed
dlenev added a commit that referenced this pull request Nov 12, 2024
…rcona.backup_safe_binlog_info test) (#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
dlenev added a commit that referenced this pull request Nov 12, 2024
…0 : Code refresh for PS 8.4.3 - post merge MTR fix (disabled percona.backup_safe_binlog_info test) (#5481)
lukin-oleksiy pushed a commit that referenced this pull request Nov 12, 2024
…rcona.backup_safe_binlog_info test) (#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
inikep pushed a commit to inikep/percona-server that referenced this pull request Nov 18, 2024
…rcona.backup_safe_binlog_info test) (percona#5481)

Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.

This test provides coverage for storing current binlog position in InnoDB redo
log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible
for storing binlog position in InnoDB redo log no longer works correctly in
general case in modern InnoDB. OTOH our backup tools no longer rely on it.

See: https://perconadev.atlassian.net/browse/PS-8897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants