-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS-9470 : Code refresh for PS 8.4.3 - post merge MTR fix (disabled pe… #5481
Merged
percona-ysorokin
merged 1 commit into
percona:release-8.4.3-3
from
dlenev:ps-9470-backup_safe_binlog_info-test-disable
Nov 11, 2024
Merged
PS-9470 : Code refresh for PS 8.4.3 - post merge MTR fix (disabled pe… #5481
percona-ysorokin
merged 1 commit into
percona:release-8.4.3-3
from
dlenev:ps-9470-backup_safe_binlog_info-test-disable
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcona.backup_safe_binlog_info test) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
percona-ysorokin
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dlenev
added a commit
that referenced
this pull request
Nov 12, 2024
…rcona.backup_safe_binlog_info test) (#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
dlenev
added a commit
that referenced
this pull request
Nov 12, 2024
…0 : Code refresh for PS 8.4.3 - post merge MTR fix (disabled percona.backup_safe_binlog_info test) (#5481)
lukin-oleksiy
pushed a commit
that referenced
this pull request
Nov 12, 2024
…rcona.backup_safe_binlog_info test) (#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 14, 2024
…rcona.backup_safe_binlog_info test) (percona#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 18, 2024
…rcona.backup_safe_binlog_info test) (percona#5481) Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins. This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it. See: https://perconadev.atlassian.net/browse/PS-8897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rcona.backup_safe_binlog_info test)
Disabled percona.backup_safe_binlog_info test which failed sporadically in Jenkins.
This test provides coverage for storing current binlog position in InnoDB redo log by LOCK TABLES FOR BACKUP. Investigation has shown that code responsible for storing binlog position in InnoDB redo log no longer works correctly in general case in modern InnoDB. OTOH our backup tools no longer rely on it.
See: https://perconadev.atlassian.net/browse/PS-8897