-
Notifications
You must be signed in to change notification settings - Fork 39
PMM-5194 Tunnels #643
base: main
Are you sure you want to change the base?
PMM-5194 Tunnels #643
Conversation
Codecov Report
@@ Coverage Diff @@
## PMM-2.0 #643 +/- ##
===========================================
+ Coverage 49.26% 49.42% +0.15%
===========================================
Files 128 123 -5
Lines 16453 15722 -731
===========================================
- Hits 8105 7770 -335
+ Misses 7603 7235 -368
+ Partials 745 717 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
models/tunnel_model.go
Outdated
|
||
//go:generate reform | ||
|
||
type TunnelType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
exported type TunnelType
should have comment or be unexported (golint)
models/tunnel_model.go
Outdated
type TunnelType string | ||
|
||
const ( | ||
ConnectTunnelType TunnelType = "connect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
exported const ConnectTunnelType should have comment (or a comment on this block) or be unexported (golint)
ListenTunnelType TunnelType = "listen" | ||
) | ||
|
||
//reform:tunnels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
comment on exported type Tunnel should be of the form "Tunnel ..." (with optional leading article) (golint)
models/tunnel_model.go
Outdated
|
||
const ( | ||
ConnectTunnelType TunnelType = "connect" | ||
ListenTunnelType TunnelType = "listen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
const ListenTunnelType
is unused (unused)
PMM-5194
Build: PMM-5194 Tunnels Percona-Lab/pmm-submodules#1459
Links to other linked pull requests (optional).