Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13629 fix pmm managed npe issue #3404

Draft
wants to merge 5 commits into
base: v3
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

PMM-13629

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 74.50980% with 39 lines in your changes missing coverage. Please review.

Project coverage is 43.52%. Comparing base (58f70a2) to head (0a19d38).

Files with missing lines Patch % Lines
managed/models/agent_model.go 77.35% 12 Missing ⚠️
managed/services/agents/agents.go 53.84% 3 Missing and 3 partials ⚠️
managed/services/inventory/agents.go 58.33% 5 Missing ⚠️
managed/services/management/mysql.go 0.00% 3 Missing ⚠️
managed/services/management/postgresql.go 0.00% 3 Missing ⚠️
managed/services/management/agent.go 91.30% 2 Missing ⚠️
managed/services/management/azure_database.go 0.00% 2 Missing ⚠️
managed/services/management/mongodb.go 0.00% 2 Missing ⚠️
managed/models/agent_helpers.go 95.45% 1 Missing ⚠️
managed/services/agents/handler.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3404      +/-   ##
==========================================
- Coverage   43.53%   43.52%   -0.02%     
==========================================
  Files         366      366              
  Lines       44238    44244       +6     
==========================================
- Hits        19261    19258       -3     
- Misses      23289    23302      +13     
+ Partials     1688     1684       -4     
Flag Coverage Δ
admin 11.47% <ø> (-0.05%) ⬇️
agent 51.83% <ø> (ø)
managed 45.28% <74.50%> (-0.02%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ua.QueryExamplesDisabled = agent.QANOptions.QueryExamplesDisabled
ua.CommentsParsingDisabled = agent.QANOptions.CommentsParsingDisabled

switch agent.AgentType {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
missing cases in switch of type models.AgentType: models.PMMAgentType, models.NodeExporterType, models.ProxySQLExporterType, models.ExternalExporterType, models.VMAgentType (exhaustive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants