Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PMM-13630]: Fixes service start issue + permissions issue #3415

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

maqeel75
Copy link
Contributor

@maqeel75 maqeel75 commented Dec 24, 2024

PMM-13630

Link to the Feature Build: SUBMODULES-0

If this PR that fixes pmm-client v3 upgrade issue that was not starting pmm-agent service and removing pmm-agent user from machine.

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@maqeel75 maqeel75 requested a review from a team as a code owner December 24, 2024 14:43
@maqeel75 maqeel75 requested review from idoqo and JiriCtvrtka and removed request for a team December 24, 2024 14:43
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (b7885f1) to head (86b61c2).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3415      +/-   ##
==========================================
- Coverage   43.57%   43.53%   -0.04%     
==========================================
  Files         366      366              
  Lines       44238    44238              
==========================================
- Hits        19275    19259      -16     
- Misses      23275    23293      +18     
+ Partials     1688     1686       -2     
Flag Coverage Δ
admin 11.47% <ø> (-0.05%) ⬇️
agent 51.83% <ø> (-0.13%) ⬇️
managed 45.29% <ø> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maqeel75 maqeel75 requested a review from ademidoff December 25, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants