PMM-5492 Adding pprof query parameter to /logs.zip #893
Conversation
api/serverpb/json/header.json
Outdated
| @@ -17,6 +17,15 @@ | |||
| "description": "Returns the PMM Server logs.", | |||
| "summary": "Logs", | |||
| "operationId": "Logs", | |||
| "parameters": [ | |||
| { | |||
| "type": "integer", | |||
There was a problem hiding this comment.
can we replace it with a boolean type?
There was a problem hiding this comment.
@BupycHuk
In JIRA ticket, we have: "User calls /logs.zip endpoint with pprof=1 query parameter" that's why I used integer here. Shall I update JIRA ticket as well?
There was a problem hiding this comment.
boolean supports pprof=1 as well and makes more sense
There was a problem hiding this comment.
Thank you for clarification. Changed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Updated with changes from pmm-managed's PR (which has archived repository): https://github.com/percona/pmm-managed/pull/1117/commits |
|
@pkadej can you please take a look at why the managed tests are failing and increase the timeout if needed? |
pkadej
force-pushed
the
PMM-5492-pprof-support
branch
from
87dcaa9 to
ec5ad60
Compare
|
@michal-kralik The problem wasn't PR related. Retriggered CI. |
PMM-5492 Add Pprof data to logs.zip
Build: SUBMODULES-2574