PMM-9968 pmm-admin inventory add agent * --log-level #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command ./bin/pmm-admin inventory add agent azure-database-exporter not exists, but exists rds-exporter and also exists in pmm-managed AgentsService::AddAzureDatabaseExporter |
… (after review)
tshcherban
previously approved these changes
Jun 2, 2022
…not -path "./vendor/*")"
BupycHuk
previously approved these changes
Jun 2, 2022
tshcherban
previously approved these changes
Jun 2, 2022
artemgavrilov
previously approved these changes
Jun 6, 2022
YaroslavPodorvanov
dismissed stale reviews from artemgavrilov, tshcherban, and BupycHuk
via
ff316c1
# Conflicts: # api/inventorypb/agents.pb.go
2 tasks
tshcherban
approved these changes
Jun 24, 2022
1 task
artemgavrilov
approved these changes
Jun 29, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -457,3 +465,11 @@ func ToAPIAgent(q *reform.Querier, agent *models.Agent) (inventorypb.Agent, erro | |||
| panic(fmt.Errorf("unhandled Agent type %s", agent.AgentType)) | |||
| } | |||
| } | |||
|
|
|||
| func SpecifyLogLevel(variant inventorypb.LogLevel) string { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
exported function SpecifyLogLevel should have comment or be unexported (golint)
| @@ -236,6 +236,7 @@ func ToAPIAgent(q *reform.Querier, agent *models.Agent) (inventorypb.Agent, erro | |||
| PushMetricsEnabled: agent.PushMetrics, | |||
| DisabledCollectors: agent.DisabledCollectors, | |||
| ProcessExecPath: processExecPath, | |||
| LogLevel: inventorypb.LogLevel(inventorypb.LogLevel_value[pointer.GetString(agent.LogLevel)]), | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
LogLevel_value contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
| @@ -457,3 +465,11 @@ func ToAPIAgent(q *reform.Querier, agent *models.Agent) (inventorypb.Agent, erro | |||
| panic(fmt.Errorf("unhandled Agent type %s", agent.AgentType)) | |||
| } | |||
| } | |||
|
|
|||
| func SpecifyLogLevel(variant inventorypb.LogLevel) string { | |||
| if variant == inventorypb.LogLevel_auto { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
LogLevel_auto contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9968
Build: SUBMODULES-2595
SUBMODULES-2536PMM-9968 pmm-admin inventory add agent * --log-level pmm-managed#1134PMM-9968 pmm-admin inventory add agent * --log-level pmm-admin#224