Validating dataset & patches #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing it does right now is make sure that periods referred to in related period fields (narrower, broader, derivedFrom) actually exist in the dataset
This function takes a raw dataset and a patch, creates an intermediary DatasetProxy from the result of applying the patch to the dataset, and then returns a new patch that is the result of going from the original dataset to the validated dataset created by the DatasetProxy. See dae853c for more details. Essentially, this is to prevent submitting patches that result in an invalid dataset-- such as including related periods that will not exist after applying the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the patch that caused an error in #267