Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamixel hardware interface for articulable fork #53

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

jjaime2
Copy link

@jjaime2 jjaime2 commented Dec 12, 2024

Description

This pull request adds the hardware interface for the Dynamixels composing the articulable fork.

Testing procedure

  • If you have access to the physical articulable fork, power it on, plug it into your computer via USB, and run build/ada_hardware/test_dynamixel
  • Verify that build/ada_hardware/test_dynamixel completes successfully
  • Run ros2 launch ada_hardware ada_hardware.launch.py sim:=mock
  • The scene in RViz2 will fail to initialize ADA's configuration since no initial configuration was given, but verify that the following logs appear
[ros2_control_node-1] [INFO] [1734045195.218359888] [resource_manager]: Successful initialization of hardware 'Jaco2'
[ros2_control_node-1] [INFO] [1734045195.218380778] [resource_manager]: Loading hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218391883] [resource_manager]: Initialize hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218401064] [resource_manager]: Successful initialization of hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218433222] [resource_manager]: 'configure' hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218436643] [resource_manager]: Successful 'configure' of hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218439227] [resource_manager]: 'activate' hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218441688] [resource_manager]: Successful 'activate' of hardware 'DynamixelHardware'
[ros2_control_node-1] [INFO] [1734045195.218443764] [resource_manager]: 'configure' hardware 'Jaco2'
[ros2_control_node-1] [INFO] [1734045195.218449818] [resource_manager]: Successful 'configure' of hardware 'Jaco2'
[ros2_control_node-1] [INFO] [1734045195.218455361] [resource_manager]: 'activate' hardware 'Jaco2'
[ros2_control_node-1] [INFO] [1734045195.218457399] [resource_manager]: Successful 'activate' of hardware 'Jaco2'

Before opening a pull request

  • pre-commit run --all-files
  • Run your code through pylint. pylint --recursive=y --rcfile=.pylintrc .. All warnings but fixme must be addressed.

Before Merging

  • Squash & Merge

@jjaime2 jjaime2 changed the base branch from jjaime2/articulable_fork_description to main December 15, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant