-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dynamixel hardware interface for articulable fork #53
Draft
jjaime2
wants to merge
37
commits into
main
Choose a base branch
from
jjaime2/dynamixel_hw_interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixel_hw_interface
…mixel_hw_interface
This reverts commit c102e12.
…mixel_hw_interface
…d in ada_standalone.xacro
…mixel_hw_interface
jjaime2
changed the base branch from
jjaime2/articulable_fork_description
to
main
December 15, 2024 03:45
…mixel_hw_interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the hardware interface for the Dynamixels composing the articulable fork.
Testing procedure
build/ada_hardware/test_dynamixel
build/ada_hardware/test_dynamixel
completes successfullyros2 launch ada_hardware ada_hardware.launch.py sim:=mock
Before opening a pull request
pre-commit run --all-files
pylint --recursive=y --rcfile=.pylintrc .
. All warnings butfixme
must be addressed.Before Merging
Squash & Merge