Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the loopback variable public in expression builder #168

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

joranmulderij
Copy link
Contributor

This is useful for complex parsers where you want the nice stuff from expression builder but don't want to loose the ability to loop back from you expression builder. For example, in my parser I have something like this:

  final builder = ExpressionBuilder<Token<Expr>>();

  final expr = builder.loopback;

expr gets used in the lines parser, which gets used in the block parser. The block parser is a primitive for the expression builder again.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (5cd0bde) to head (3b7b764).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         105      105           
  Lines        2153     2153           
=======================================
  Hits         2131     2131           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renggli renggli merged commit 20ba2c1 into petitparser:main Feb 29, 2024
3 checks passed
@renggli
Copy link
Member

renggli commented Feb 29, 2024

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants