Skip to content

Commit

Permalink
Merge pull request #62 from phansch/fix-mac-chromedriver-install
Browse files Browse the repository at this point in the history
Fix Chromedriver installation on macos
  • Loading branch information
phansch authored Aug 21, 2024
2 parents 8bc6253 + 70134c9 commit b236a72
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/chromedriver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ impl DriverFetcher for Chromedriver {
}

Err(eyre!("Could not find the latest version"))
}
}

/// Returns the download url for the driver executable
fn direct_download_url(&self, version: &str) -> Result<Url> {
Expand Down Expand Up @@ -65,7 +65,7 @@ impl Chromedriver {
fn platform() -> Result<String> {
match std::env::consts::OS {
"linux" => Ok(String::from("linux64")),
"macos" => Ok(String::from("mac64")),
"macos" => Ok(String::from("mac-x64")),
"windows" => Ok(String::from("win32")),
other => Err(eyre!(
"webdriver-install doesn't support '{}' currently",
Expand Down Expand Up @@ -312,7 +312,7 @@ fn direct_download_url_test() {
);
#[cfg(target_os = "macos")]
assert_eq!(
"https://storage.googleapis.com/chrome-for-testing-public/v1/mac64/chromedriver-mac64.zip",
"https://storage.googleapis.com/chrome-for-testing-public/v1/mac-x64/chromedriver-mac-x64.zip",
Chromedriver::new()
.direct_download_url("v1")
.unwrap()
Expand Down

0 comments on commit b236a72

Please sign in to comment.