Fix select attribute on larger tables

phibr0 · Mar 26, 2022 · 10a294f · 10a294f
1 parent 771e33b
commit 10a294f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
     "id": "obsidian-charts",
     "name": "Obsidian Charts",
-    "version": "3.4.7",
+    "version": "3.5.0",
     "minAppVersion": "0.12.7",
     "description": "This Plugin lets you create Charts within Obsidian",
     "author": "phibr0",

diff --git a/src/chartFromTable.ts b/src/chartFromTable.ts
@@ -27,20 +27,16 @@ export function generateTableData(table: string, layout: 'columns' | 'rows', sel
         throw error;
     }
     const labels = Object.keys(Object.values(fields)[0]);
-    const dataFields: DataField[] = Object.keys(fields).map((key) => {
+    let dataFields: DataField[] = Object.keys(fields).map((key) => {
         return {
             dataTitle: key,
             data: Object.values(fields[key]) as string[]
         }
     });
 
     if(selected) {
-        dataFields.filter((v) => {
-            if(!selected.contains(v.dataTitle)) {
-                dataFields.remove(v)
-            }
-        });
+        dataFields = dataFields.filter(value => selected.contains(value.dataTitle));
     }
-    
+
     return {labels, dataFields};
 }