Conditionally require discussion category

Only required when creating a repo discussion Fixes #40
philip-gai · Dec 2, 2021 · d8835c2 · d8835c2
1 parent 45d4977
commit d8835c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/web-app/src/eventHandlers/pullRequestEventHandler.ts b/web-app/src/eventHandlers/pullRequestEventHandler.ts
@@ -438,7 +438,7 @@ Please fix the issues and recreate a new PR:
     }
     const discussionCategoryMatch = repoDiscussionCategories.find(
       (node) =>
-        node?.name.trim().localeCompare(parsedItems.discussionCategoryName, undefined, {
+        node?.name.trim().localeCompare(parsedItems.discussionCategoryName!, undefined, {
           sensitivity: 'accent'
         }) === 0
     );

diff --git a/web-app/src/services/parserService.ts b/web-app/src/services/parserService.ts
@@ -6,7 +6,7 @@ export interface ParsedMarkdownDiscussion {
   repoOwner: string | undefined;
   team: string | undefined;
   teamOwner: string | undefined;
-  discussionCategoryName: string;
+  discussionCategoryName: string | undefined;
   postBody: string;
   postTitle: string;
   author: string;
@@ -86,7 +86,9 @@ export class ParserService {
     return teamName;
   }
 
-  public getDiscussionCategoryName(): string {
+  public getDiscussionCategoryName(): string | undefined {
+    const repoUrl = this.getTargetRepoUrl();
+    if (!repoUrl) return;
     const rawCat = this._yamlHeader.category as string;
     const categoryName = rawCat?.split('/').pop()?.trim();
     if (!categoryName) throw new Error('Unable to get discussion category');