Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Enterprise setting as env var #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RichardLitt
Copy link
Contributor

Here, I add process.env.GITHUB_ENDPOINT as a possible environmental var
to use to change the rootURL. I change all instances of rootURL to
githubEndpoint, as that is the token used in gh-got
and it seemed like a good idea to just copy that token.

I was unsure of how to add a test for this.

Here, I add process.env.GITHUB_ENDPOINT as a possible environmental var
to use to change the rootURL. I change all instances of `rootURL` to
`githubEndpoint`, as that is the token used in [`gh-got`](https://github.com/sindresorhus/gh-got)
and it seemed like a good idea to just copy that token.

I was unsure of how to add a test for this.
@RichardLitt
Copy link
Contributor Author

Just realized changing rootURL to githubEndpoint will break functionality for others. So, that may not be advised. Happy to change it back. Having a default env var would still be useful.

I resolved my issues in RichardLitt/gh-description#12 using rootURL, so this PR is no longer necessary for me, but it may still be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant