Improve effort in keeping render_upload provided percentage #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LostKobrakai can you fixup the conflicts? |
…e as the calculated percentage of `progress_stats`
LostKobrakai
force-pushed
the
LostKobrakai-patch-1
branch
from
a0d2c10 to
3e18363
Compare
|
I've rebased the changes. I also noticed I didn't leave an example. Say you upload a 50byte file. There's no way to upload 1% of that. The smallest increment one can upload for that file is 2%. I discovered this issue with the existing behaviour, as uploading 99% and then 1% of a file didn't fully upload it. The 99% would effectively upload 98% and then additional 2% were needed to complete the upload. |
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find a good place to test those changes.
This should prevent surprises, where
render_upload(…, percentage)results in a different percentage of actually uploaded file.