Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update_many/1 to LiveComponent #2809

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Add update_many/1 to LiveComponent #2809

merged 3 commits into from
Sep 20, 2023

Conversation

josevalim
Copy link
Member

@dvic I pushed docs and migrated to update_many/1. Please give it a try and let me know how it goes.

dvic
dvic approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dvic dvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like update_many/1 better than update_many/2! Looking good from first glance, I'll see if I can find time later this week to try it out on a real project, but for now LGTM 👍

@josevalim josevalim merged commit 97dabd1 into main Sep 20, 2023
4 of 6 checks passed
@josevalim
Copy link
Member Author

💚 💙 💜 💛 ❤️

@josevalim josevalim deleted the jv-update-many-2 branch September 20, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvic dvic dvic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josevalim @dvic