Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo/Video viewer redesign #20

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ddshd
Copy link
Contributor

@ddshd ddshd commented Mar 1, 2023

  • Images now open to the full screen view
  • Navigation Buttons to take users to the details/download page
  • Full screen video (Contains PIP support)
  • Overall updates to make it work like a standard photos app

This should addresses the requests and concerns people had with the image viewer. Let me know if you'd like me to add some demo images/videos to this PR. Will need to setup a test user but I can make it happen.

Addresses: #19, #15, #4

@ddshd ddshd mentioned this pull request Mar 1, 2023
@viktorstrate
Copy link
Member

Thank you for your efforts! Let me know when you feel the PR is ready for review.
If you can (maybe with screenshots or video) describe the changes you've made and show how to test them, it will help really help out.

@ddshd
Copy link
Contributor Author

ddshd commented Mar 6, 2023

The PR is ready for review.. I've added a demo video, it should showcase:

  • Pinch to scroll
  • Scrolling through media
  • Video player
  • PIP Video player
  • The info/details screen (I didn't have a sample image with exif data, however, it will appear above the Download options. This should be somewhat visible at 1:02)
  • Integration with the timeline (The same behavior when tapped from Places, or Faces views)

The video is compressed because of GIthub's file limit:
https://user-images.githubusercontent.com/17243132/223235037-a34a3c15-cd37-4c5d-a6de-a69fd10d97d8.mp4

@apat183
Copy link

apat183 commented Apr 11, 2023

This is great update. Just came here to request this as a new PhotoView user. Can't wait for this to be merged

@ghost
Copy link

ghost commented May 27, 2023

Any update on when this will be merged? I'd love to see these changes implemented into the app! :)

@PubBow
Copy link

PubBow commented Oct 20, 2023

Not sure if this is the right place to comment. I have just started using Photoview and it's a great product so I signed up to Git just to comment.

I had some issues with the manual install documentation but got it working.

As mentioned by @apat183 - looking forward to the iOS update to make the app a standard photos app which is currently letting the product down.

@Krzysiulek
Copy link

Krzysiulek commented Oct 19, 2024

Hi @viktorstrate @ddshd. Is there any chance to merge this PR and publish it to AppStore? I love this app and would like to be able to fullscreen my photos and videos on ios device.

@ddshd
Copy link
Contributor Author

ddshd commented Oct 27, 2024

Hi @viktorstrate @ddshd. Is there any chance to merge this PR and publish it to AppStore? I love this app and would like to be able to fullscreen my photos and videos on ios device.

Not sure what the future of the Photoview project is with the new maintainer(s).. It would be up to them to see how/what they'd like to merge in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants