Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wayland #242

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Feature/wayland #242

wants to merge 12 commits into from

Conversation

phuhl
Copy link
Owner

@phuhl phuhl commented Aug 5, 2023

Mostly working wayland version.

Remaining issue:

  • Detection what monitor the pointer is on seems impossible. That means, only fixed monitors are working atm

@phuhl
Copy link
Owner Author

phuhl commented Aug 5, 2023

#26

@kepi
Copy link

kepi commented Oct 17, 2023

Starting to use this as my daily driver, thanks. First report - notifications are notifying :) so looks promising.

Are you looking for some specific areas to test? Would be great to have this merged.

Small glitch maybe - when I toggle sidebar on the side with cursor in its area, sidebar dissapears when I move the cursor outside sidbar's area. Doesn't bother me too much, just not sure if it was same in X. It is little problematic when I try to close some notification with icon and i move one more pixel to the right on next monitor and it dissapears.

@phuhl
Copy link
Owner Author

phuhl commented Oct 18, 2023

Hey @kepi,

Starting to use this as my daily driver, thanks. First report - notifications are notifying :) so looks promising.

Very good :)

Are you looking for some specific areas to test? Would be great to have this merged.

Does it work well on your device, do you have any issues in general? Nothing specific really.

Small glitch maybe - when I toggle sidebar on the side with cursor in its area, sidebar dissapears when I move the cursor outside sidbar's area. Doesn't bother me too much, just not sure if it was same in X. It is little problematic when I try to close some notification with icon and i move one more pixel to the right on next monitor and it dissapears.

Might this be the configured behavior?

image

In that case, you can just disable it, see the Readme for details. Hope that helps.

@kepi
Copy link

kepi commented Oct 18, 2023

@phuhl mea culpa, I just thought it wasn't acting like this on X, so I didn't check the config before writing. Working like a charm, thanks!

Everything else is really great, I didn't hit any error at all since yesterday. If something unexpected happens, I'll check the config :) and let you know. But so far its working and rock solid.

@leon-erd
Copy link

Also started using this as daily driver now on Hyperland. Works well so far!
Blur can be enabled with: layerrule = blur, deadd-notification-center in hyprland.conf
Just a bit confused with the styling options :D (cannot set .userbuttonlabel hover color - none of the classes in the default CSS seem to have an effect)
Other than that I really love the program. Looks great!

@phuhl
Copy link
Owner Author

phuhl commented Nov 23, 2023

@leon-erd I don't experience issues with CSS, maybe there is an issue with the location where you put it?

@leon-erd
Copy link

@phuhl the CSS file works fine. It's just that I cannot change the label color of hovered buttons in the notification center.
Labelcolor seems to be only effected by .userbuttonlabel and not by .userbuttonlabel:hover, .userbuttonlabel.buttonState1:hover or .userbuttonlabel.buttonState2:hover
But as this is not something wayland specific it should probably be discussed in another thread.

One thing I noticed however which could be wayland specific is the following:
I have a waybar at the top which has a width of 36px. If I do not define a margin for the notification center a part of the buttons is outside the screen at the bottom. So I have to explicitly define margin-bottom: 36.
When I restart the waybar there is a gap (of 36px) at the bottom between the notification center and the edge of the screen. After a few mouse clicks inside and outside the notification center the gap disappears.

2023-11-23_12-19
Bottom part cut off (default when margin-bottom: 0;)

20231123_12h15m22s_grim
Gap when restarting waybar (with margin-bottom: 36;)

One thing that I noticed when making the screenshots:
Screenshot with grim shifts the window upwards (same as restarting waybar -> gap with margin-bottom: 36 / correctly aligned with margin-bottom: 0) while screenshot with flameshot doesn't.

@phuhl
Copy link
Owner Author

phuhl commented Nov 24, 2023

Hm, interesting behavior indeed. Not sure if I can do anything about that, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants