Adding symbolic links #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
pierDipi
force-pushed
the
jobsink
branch
5 times, most recently
from
31c954c to
6034d5d
Compare
pierDipi
pushed a commit
that referenced
this pull request
Aug 1, 2024
…ger (knative#7933) * data plane changes * moved global variables inside function * updated other functions * feature flag * verifying events get delivered * main test * test for broker in different namespace * changed to two environments * updated namespace variables * moved feature flag prerequisite * fix global undefined problem * updated creating namespace * ctx variable name update * getting rid of trigger goes ready since it's done in feature * adding withbrokerref option for trigger install * changing the way parameter is passed in * refactor brokername parameter * clean up unused variables * added missing broker name * deleted unused parameter * enabling feature flag * fixed argument * cleaned up unused variable * manually resolving URL for sending events * use StartSenderToNamespacedResource * Update code * comments clean up * Update go.mod * Update go.sum * Update modules.txt * Update forwarder.go * update codegen * debug unit test * comments clean up * clean up unused variables * undo changes to owners_aliases * updated broker filter handler * install broker * install trigger and broker * adding subscriber to triggerCfg * added withbrokerref function * updated filter handler checks * updated broker in reportArgs * updated broker handling in handleDispatchToSubscribeRequest * updated brokerref in handleDispatchToReplyRequest * updated WithBrokerRef fcn * fix(test): the crossnamespace e2e test passes now (#1) Signed-off-by: Calum Murray <[email protected]> * fixed typo * fix: feature flags are passed correctly (#2) Signed-off-by: Calum Murray <[email protected]> * Update test/rekt/crossnamespace_test.go Co-authored-by: Calum Murray <[email protected]> * Update test/rekt/features/broker/crossnamespace.go Co-authored-by: Calum Murray <[email protected]> * Update test/rekt/features/trigger/crossnamespace.go Co-authored-by: Calum Murray <[email protected]> * cleaned up comments --------- Signed-off-by: Calum Murray <[email protected]> Co-authored-by: Calum Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found them handy when applying the POC to my cluster