Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OpenSplat easier to package for distros #82

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

jcaesar
Copy link
Contributor

@jcaesar jcaesar commented Apr 20, 2024

Hey, I'm trying to package OpenSplat for NixOS. OpenSplat is a fun tool and I'd like to see it get packaged in other distros, too.

One thing that distros dislike (some even forbid strictly) is using vendored dependencies, for various reasons, but mostly because it makes it difficult to track which versions of a project are used, and can make cleaning up security issues a lot more difficult.

The effect that the vendored dependencies achieve so far (making OpenSplat easy to build) can also be achieved by using CMake's FetchContent, which will download a fixed version of the dependencies (unless explicitly told not to, with -DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=ALWAYS). This PR adds that. As an added benefit, this also documents exactly which versions of the dependencies are being used, and where they are taken from.

PS: As a small aside, this also adds install calls for the opensplat binary, so the normal cmake && make && make install will work and automatic packaging scripts can do their thing.

PPS: gsplat is heavily modified, right? I don't think it can be unvendored. It is, in effect, a fork.

@pierotofy
Copy link
Owner

Thanks @jcaesar ! This looks great and should make it easier to upgrade libraries in the future 🙏

Yes gsplat is not really vendored, we've made some changes to it. At some point we'll probably rename it to avoid confusion.

@pierotofy pierotofy merged commit 2dc4583 into pierotofy:main Apr 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants