Additions required for simson trade module

[Merjo]

No description provided.

[SallyDa]

It's looking much cleaner, thanks! Still a few minor comments, but all up for discussion, since I'm not fully convinced either way :)

[SallyDa]

Potentially would be nice to have this with an inplace: bool=True option, along with the **kwargs. I guess it could be useful for debugging to make the Trade that has been balanced as a separate object from the starting unbalanced Trade object. But, this makes me think that we don't need it as an abstractmethod. Still undecided tbh. What do you think?

[Merjo]

I like the idea of having the inplace option - I guess we could then have this function as not an abstract method but something like

class BalancedTrade(Trade)
    def balance(self, inplace : bool=True, **kwargs):
        if inplace:
            self.balance_function(**kwargs)
        else:
            new_trade = self.__class__(imports=self.imports, exports=self.exports)
            new_trade.balance_function(**kwargs)
            return new_trade

    @abstractmethod
    def balance_function(**kwargs):
        pass

class SpecificBalancedTrade(BalancedTrade):
    def balance_function(**kwargs):
        #foo

This way every balanced trade instance still has the balance function, the inplace works and you can specify what happens via the (abstract) balance_function in the subclasses (feel free to suggest a better name :) ). Or is that overcomplicating it? Just would like to keep the general idea.

[Merjo]

Another option could be to call it '_balance' instead of 'balance_function' to make it clear that one is for public use and the other for internal use.

[SallyDa]

Looks great :)

[SallyDa]

Thanks @Merjo! The trade module has been moved out of sodym, so this pr only has extra named_dim_array functionality :) Want to take a look @JakobBD?

[JakobBD]

Already did, looks great!

[JakobBD]

Thanks to both of you!