Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: close kvclient correctly when stopping a processor #11957

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 31, 2024

What problem does this PR solve?

Issue Number: close #11954

What is changed and how it works?

When stopping a processor, close the associated puller.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
[2024/12/31 16:21:32.261 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3_owner_ddl_puller]
[2024/12/31 16:21:32.270 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3_owner_ddl_puller]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3_processor_ddl_puller]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3_processor_ddl_puller]

With the patch, when removing a changefeed, all pullers for owner_ddl, processor_ddl and source_manager are closed.
No goroutine leak happens any more.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Dec 31, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2024
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 31, 2024
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-31 06:52:29.965721031 +0000 UTC m=+419685.321725627: ☑️ agreed by 3AceShowHand.
  • 2024-12-31 08:30:29.133503693 +0000 UTC m=+425564.489508232: ☑️ agreed by asddongmen.

@hicqu
Copy link
Contributor Author

hicqu commented Jan 2, 2025

/retest

2 similar comments
@hicqu
Copy link
Contributor Author

hicqu commented Jan 6, 2025

/retest

@hicqu
Copy link
Contributor Author

hicqu commented Jan 6, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

@hicqu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 602f586 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 80f49c6 into pingcap:master Jan 6, 2025
27 checks passed
@hicqu hicqu deleted the close-shared-client branch January 6, 2025 12:01
@hicqu hicqu added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 6, 2025
@hicqu hicqu added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 6, 2025
@hicqu
Copy link
Contributor Author

hicqu commented Jan 6, 2025

/cherry-pick

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11980.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11981.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiCDC: Goroutine leak in unboundedProcessing
4 participants