Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix rename table across database #11964

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Jan 2, 2025

What problem does this PR solve?

Issue Number: close #11963

What is changed and how it works?

Construct a rename table query which contains database name and table name in the ddl event.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fixed the issue that rename table ddl cannot be synchronized in some cases.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 2, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lidezhu, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.2675%. Comparing base (91902aa) to head (9626b53).

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.7326% <0.0000%> (+0.0079%) ⬆️
dm 50.1363% <ø> (-0.0039%) ⬇️
engine 53.2336% <ø> (+0.0112%) ⬆️
Flag Coverage Δ
unit 55.2675% <0.0000%> (+0.0041%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11964        +/-   ##
================================================
+ Coverage   55.2634%   55.2675%   +0.0041%     
================================================
  Files          1004       1004                
  Lines        137733     137739         +6     
================================================
+ Hits          76116      76125         +9     
+ Misses        56048      56047         -1     
+ Partials       5569       5567         -2     

@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 2, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 2, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2025

@lidezhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify c99eece link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to rename table to another db‘s table
1 participant