Refactor pin states

pipe01 · Oct 28, 2024 · 9e9533f · 9e9533f
1 parent d87a434
commit 9e9533f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/include/pins.h b/include/pins.h
@@ -45,3 +45,4 @@ uint32_t pins_get_latch(pins_t *);
 void pins_set_latch(pins_t *, uint32_t latch);
 
 bool pins_is_set(pins_t *, int pin);
+uint32_t pins_read_all(pins_t *);
diff --git a/src/pins.c b/src/pins.c
@@ -7,18 +7,17 @@
 
 typedef struct
 {
-    bool is_set;
-
     pindir_t dir;
     pinsense_t sense;
 } pin_t;
 
 struct pins_t
 {
     pin_t pins[PINS_COUNT];
+    uint32_t pin_states;
+    static_assert(PINS_COUNT == 32, "PINS_COUNT is not 32");
 
     uint32_t latch;
-    static_assert(PINS_COUNT == 32, "PINS_COUNT is not 32");
 };
 
 pins_t *pins_new()
@@ -40,11 +39,14 @@ static inline void pins_set_state(pins_t *pins, int pin, bool is_set)
 {
     assert(pin >= 0 && pin < PINS_COUNT);
 
-    pin_t *p = &pins->pins[pin];
-    if (p->is_set == is_set)
+    is_set = is_set ? 1 : 0; // Normalize to 0 or 1
+
+    if (pins_is_set(pins, pin) == is_set)
         return;
 
-    p->is_set = is_set;
+    pin_t *p = &pins->pins[pin];
+
+    pins->pin_states = (pins->pin_states & ~(1 << pin)) | (is_set << pin);
 
     if (p->sense != SENSE_DISABLED && ((is_set && (p->sense == SENSE_HIGH)) || (!is_set && (p->sense == SENSE_LOW))))
         pins->latch |= 1 << pin;
@@ -69,7 +71,12 @@ bool pins_is_set(pins_t *pins, int pin)
 {
     assert(pin >= 0 && pin < PINS_COUNT);
 
-    return pins->pins[pin].is_set;
+    return (pins->pin_states & (1 << pin)) != 0;
+}
+
+uint32_t pins_read_all(pins_t *pins)
+{
+    return pins->pin_states;
 }
 
 pindir_t pins_get_dir(pins_t *pins, int pin)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -45,3 +45,4 @@ uint32_t pins_get_latch(pins_t *);
		void pins_set_latch(pins_t *, uint32_t latch);

		bool pins_is_set(pins_t *, int pin);
		uint32_t pins_read_all(pins_t *);