make http handler take an optional requests.Session #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arondaniel can you pull latest develop? it contains some changes on CI that touch requests/urllib3 |
ddelange
reviewed
Aug 21, 2024
ddelange
reviewed
Aug 21, 2024
|
Thank you @arondaniel and @ddelange ! |
ddelange
added a commit
to ddelange/smart_open
that referenced
this pull request
Oct 28, 2024
mpenkov
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Makes http handler take an optional requests.Session object
Motivation
Fixes #792
Allows passing in a custom requests.Session object via smart_open.open transport_params. The Session object can support OAUTH2 authentication.
Tests
Added test for setting session attribute.