Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 and Tycho 4 #226

Merged
merged 8 commits into from
Mar 31, 2024
Merged

Java 17 and Tycho 4 #226

merged 8 commits into from
Mar 31, 2024

Conversation

LorenzoBettini
Copy link
Collaborator

Closes #225
Closes #215

Note that the older target has been upgraded to 2021-12 which is the first Eclipse version support Java 17. Photon is way too old and UI tests fail for JUnit 5 (it's useless trying to build with such an ancient version).

This PR also uses the new version of setup-java action.

@LorenzoBettini
Copy link
Collaborator Author

opps... I had forgotten to update the Tycho version in .mvn/extensions-xml; done that now

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@echebbi echebbi merged commit b9bd59d into master Mar 31, 2024
11 checks passed
@echebbi echebbi deleted the 225-java17-tycho4 branch March 31, 2024 11:19
@echebbi
Copy link
Collaborator

echebbi commented Apr 3, 2024

@LorenzoBettini I just noticed that our manifests are still requiring Java 1.8:

Bundle-RequiredExecutionEnvironment: JavaSE-1.8

Couldn't/shouldn't we upgrade to at least Java 11 as per our target platform? IIRC as of v2022-09 Eclipse's core bundles were already requiring Java 11 (maybe even Java 17 according to this page).

@LorenzoBettini
Copy link
Collaborator Author

@echebbi Yes, I always favored upgrading to newer Java, even Java 17. I seem to recall that you were reluctant to require newer Java versions as a minimal running environment ;)

Do you want me to address the move to Java 17 (or do you prefer Java 11?) in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Tycho 4 and Java 17 Test failures with Java 17
2 participants