-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 and Tycho 4 #226
Java 17 and Tycho 4 #226
Conversation
opps... I had forgotten to update the Tycho version in |
Quality Gate passedIssues Measures |
@LorenzoBettini I just noticed that our manifests are still requiring Java 1.8: Bundle-RequiredExecutionEnvironment: JavaSE-1.8 Couldn't/shouldn't we upgrade to at least Java 11 as per our target platform? IIRC as of v2022-09 Eclipse's core bundles were already requiring Java 11 (maybe even Java 17 according to this page). |
@echebbi Yes, I always favored upgrading to newer Java, even Java 17. I seem to recall that you were reluctant to require newer Java versions as a minimal running environment ;) Do you want me to address the move to Java 17 (or do you prefer Java 11?) in another PR? |
Closes #225
Closes #215
Note that the older target has been upgraded to 2021-12 which is the first Eclipse version support Java 17. Photon is way too old and UI tests fail for JUnit 5 (it's useless trying to build with such an ancient version).
This PR also uses the new version of
setup-java
action.