Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tier update reports #12

Open
scheibo opened this issue Aug 27, 2024 · 3 comments
Open

Refactor tier update reports #12

scheibo opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
stats Issue related to @pkmn/stats

Comments

@scheibo
Copy link
Contributor

scheibo commented Aug 27, 2024

async tierUpdateReport(
provides an example that at one point implemented tier update reports correctly for the singles metagame at the time. It needs to be updated to match the reports produced by https://github.com/smogon/usage-stats/blob/main/TierUpdate9Singles.py, though likely can also be simplified somewhat (see for example #5)

Furthermore, we need the following reports to be added:

Finally, all of these reports need to be tested, so this is blocked on #3

@scheibo scheibo added good first issue Good for newcomers stats Issue related to @pkmn/stats labels Aug 27, 2024
@scheibo
Copy link
Contributor Author

scheibo commented Aug 27, 2024

This is a good first issue because it is:

a) simply porting logic
b) very contained and doesn't involve much knowledge of anything else within this repository, its mostly just a question of implementing one (complicated) function
c) it is very easy to test - unlike logs/stats processing which relies on (private) logs data, the usage reports rely on data which is fully public

@scheibo
Copy link
Contributor Author

scheibo commented Sep 20, 2024

July seems like a good month to update the reports tesdts to https://www.smogon.com/forums/threads/usage-based-tier-update-for-july-2024-august-38-september-52.3746220/

@scheibo scheibo unpinned this issue Sep 22, 2024
@scheibo
Copy link
Contributor Author

scheibo commented Sep 22, 2024

OK these are technically all implemented, though the implementation feels like it could use some cleaning up. Going to repurpose the issue to be a sanity check + refactoring

@scheibo scheibo removed the good first issue Good for newcomers label Sep 22, 2024
@scheibo scheibo changed the title Implement tier update reports Refactor tier update reports Sep 22, 2024
@scheibo scheibo self-assigned this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stats Issue related to @pkmn/stats
Development

No branches or pull requests

1 participant