Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This PR changes the behaviour of
SearchSelectFilterInput
such that it is now possible to use a multi-value (input_html: { multiple: true }
) input.Detail
I needed the search select filter with multiple values in my app, within the same model (e.g. filtering
User.name
in the ActiveAdminUser
page).Currently, to the best of my knowledge, this was not possible because
SearchSelectFilterInput#input_method
was hardcoded to useeq
, which breaks ransack at some point with an error like "cannot use eq for [123, 456]" if you try to usemultiple: true
.This PR changes
SearchSelectFilterInput#input_method
to use an appropriate predicate for lists (in
) when needed (e.g. wheninput_html: { multiple: true }
).I had to update some minor gem versions to get bin/setup working.
Additional information
Checklist
Before submitting the PR make sure the following are checked: