Skip to content
This repository has been archived by the owner on Nov 24, 2017. It is now read-only.

package.json compatible with Angular 4 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

package.json compatible with Angular 4 #66

wants to merge 1 commit into from

Conversation

istreeter
Copy link

I would like to update my app to angular 4, which is backwards compatible with angular 2. Currently I cannot update by I get this error message:

npm WARN [email protected] requires a peer of @angular/core@^2.0.0 but none was installed.

This can be fixed by changing peerDependencies to "^2.0.0 || ^4.0.0"

It would be great if you could accept this pull request so that I can update my app whilst still using ngx-popover.

I would like to update my app to angular 4, which is backwards compatible with angular 2. Currently I cannot update by I get this error message:

npm WARN [email protected] requires a peer of @angular/core@^2.0.0 but none was installed.

This can be fixed by changing peerDependencies to "^2.0.0 || ^4.0.0"

It would be great if you could accept this pull request so that I can update my app whilst still using ngx-popover.
@deskenazi
Copy link

Same here. Thank you in advance.

@jonnysamps
Copy link

Ya, we need this too. Thanks!

@guan01
Copy link

guan01 commented May 31, 2017

Yes please

@HFlorina
Copy link

That would be great !

@WillyReyno
Copy link

Really needed, hope it will be merged soon :)

@jonnysamps
Copy link

Hey all, just wanted to point out that the README states pretty clearly that this repo will NOT be maintained. So I wouldn't hold out hope.

@istreeter
Copy link
Author

Yeah, I noticed that after I made the pull request. So I found this fork to use instead: https://github.com/ctubio/ng4-popover. I'm leaving this pull request open just in case.

@masoudline
Copy link

Hi how can i append popover to body?
I tried data-container='body' but it not working!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants