update dashboard JS to ES2015 with recommended WPCS style #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve ES5 for the tracking snippet for maximum compatibiltiy. The dashboard requires some modern logic for the Bakcbone API client already so let's migrate our script to ES2015 as well. We also split the large update routine into multiple methods in preparation for additional visualizations. This change finally drops IE11 support for the admin dashboard.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve ES5 for the tracking snippet for maximum compatibiltiy. The dashboard requires some modern logic for the Bakcbone API client already so let's migrate our script to ES2015 as well.
We also split the large update routine into multiple methods in preparation for additional visualizations.
This change finally drops IE11 support for the admin dashboard.