Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datatype number for search #857

Merged
merged 3 commits into from
Dec 26, 2024
Merged

fix: datatype number for search #857

merged 3 commits into from
Dec 26, 2024

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Nov 18, 2024

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.

Description

  • It fixes !35167
  • Change the decimal type of number fields to display the decimal part of the decimal numbers in search options

Screenshots (if appropriate):

Capture d’écran du 2024-11-18 14-11-57

@stonebuzz
Copy link
Contributor

Does searching with < still work?

@MyvTsv
Copy link
Contributor Author

MyvTsv commented Nov 18, 2024

Does searching with < still work?

Yes the operator is functional

Capture d’écran du 2024-11-18 15-15-19
Capture d’écran du 2024-11-18 15-15-11

@stonebuzz stonebuzz added the bug label Nov 18, 2024
@stonebuzz
Copy link
Contributor

Can you propose a patch to the user to get another validation that it works properly?

Rom1-B
Rom1-B requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, waiting customer feedback.

@stonebuzz
Copy link
Contributor

@MyvTsv can you adapt ``CHANGELOG.md`

@stonebuzz stonebuzz added this to the 1.21.17 milestone Dec 19, 2024
@stonebuzz stonebuzz self-requested a review December 26, 2024 13:33
stonebuzz
stonebuzz requested changes Dec 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@stonebuzz stonebuzz merged commit decd5bc into pluginsGLPI:main Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

Assignees

@MyvTsv MyvTsv

Labels
bug need feedback
Projects
None yet
Milestone
1.21.17
Development

Successfully merging this pull request may close these issues.
3 participants
@MyvTsv @stonebuzz @Rom1-B