Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import access restrictions may ignore uuids #3384

Merged

Conversation

btry
Copy link
Collaborator

@btry btry commented Oct 4, 2023

Changes description

When adding or updating a form, if $input contains keys 'users', 'profiles' or 'groups' they are processed in post_addItem() or post_updateItem(). We need to prevent this when the form is being imported, or UUIDs of rows in forms_profiles, forms_groups and forms_users will be added without their UUID

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

References

Closes #N/A

@btry btry added the bug label Oct 4, 2023
@btry btry self-assigned this Oct 4, 2023
@btry btry force-pushed the bugfix/form_restriction_import branch from 6971a6c to a91cc84 Compare October 4, 2023 11:46
@btry btry force-pushed the bugfix/form_restriction_import branch from a91cc84 to cb5aa43 Compare October 5, 2023 06:47
@btry btry merged commit 4eaa35f into pluginsGLPI:support/2.13.0 Oct 5, 2023
4 checks passed
@btry btry deleted the bugfix/form_restriction_import branch October 5, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant