Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(massiveAction): Fixed bug preventing the addition of tags to objects without creation rights #220

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(massiveAction): Fixed bug preventing the addition of tags to objects without creation rights #220

wants to merge 6 commits into from

Conversation

MyvTsv
Copy link

@MyvTsv MyvTsv commented Dec 4, 2024

  • I have performed a self-review of my code.

Description

  • It fixes !35473
  • This PR fixes an issue that prevents users without authoring rights on a given object type from adding tags to these objects. To add a tag, you must have the right to update the object.

Rom1-B
Rom1-B requested changes Dec 4, 2024
View reviewed changes
inc/tag.class.php Outdated Show resolved Hide resolved
@MyvTsv MyvTsv requested a review from Rom1-B December 5, 2024 09:32
Rom1-B
Rom1-B requested changes Dec 5, 2024
View reviewed changes
inc/tag.class.php Outdated Show resolved Hide resolved
@MyvTsv MyvTsv requested a review from Rom1-B December 5, 2024 12:53
Rom1-B
Rom1-B requested changes Dec 5, 2024
View reviewed changes
inc/tag.class.php Outdated Show resolved Hide resolved
inc/tag.class.php Outdated Show resolved Hide resolved
@MyvTsv MyvTsv requested a review from Rom1-B December 6, 2024 08:18
Rom1-B
Rom1-B approved these changes Dec 6, 2024
View reviewed changes
inc/tag.class.php Outdated Show resolved Hide resolved
inc/tag.class.php Outdated Show resolved Hide resolved
@Rom1-B Rom1-B requested a review from stonebuzz December 6, 2024 08:29
stonebuzz
stonebuzz approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you ask for a customer test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

Assignees
No one assigned
Labels
Need feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MyvTsv @stonebuzz @Rom1-B