Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the caching of some more cluster fields plus other changes #1709

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Optimize the caching of some more cluster fields plus other changes #1709

merged 4 commits into from
Dec 30, 2024

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Dec 23, 2024 •
edited
Loading

Some fields were falling back to k8s in-line which can be slow when clusters are unavailable, this reads only from cache and nils if a miss

Also implements:

  • pr generation from chat threads
  • copying context into chat threads
  • graphql-ws support to potentially fix absinthe issues.

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Dec 23, 2024
@michaeljguarino michaeljguarino requested a review from a team December 23, 2024 01:28
@michaeljguarino michaeljguarino force-pushed the better-nodes-caching branch 16 times, most recently from 53cc5af to b7bbce5 Compare December 24, 2024 19:37
@michaeljguarino
Optimize the caching of some more cluster fields
9c32ac2 
Some fields were falling back to k8s in-line which can be slow when clusters are unavailable, this reads only from cache and nils if a miss
@michaeljguarino michaeljguarino force-pushed the better-nodes-caching branch 11 times, most recently from 70a0aa8 to 40d31cb Compare December 26, 2024 00:02
@michaeljguarino michaeljguarino force-pushed the better-nodes-caching branch 11 times, most recently from 5b5bbae to ab3b9b1 Compare December 28, 2024 02:17
@michaeljguarino michaeljguarino changed the title Optimize the caching of some more cluster fields Optimize the caching of some more cluster fields plus other changes Dec 30, 2024
@michaeljguarino michaeljguarino merged commit c5ec408 into master Dec 30, 2024
10 checks passed
@michaeljguarino michaeljguarino deleted the better-nodes-caching branch December 30, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsladerman jsladerman jsladerman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @jsladerman