Use git rev-parse
instead of gogit.Repository.Head() to find out head branch & sha
#461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When working in a
git worktree
rather than a full clone,plural build
fails:I managed to track it down to
gogit.Repository.Head()
function: it seems to try to directly access objects in.git/
. In worktree,.git
is a file with reference to a parent repository, so there's no.git/HEAD
.This change uses actual
git
CLI instead of an incomplete reimplementation to get HEAD SHA and branch name. This makes Plural CLI work in agit worktree
.Some unrelated unit tests are failing, haven't touched these.
Labels
Test Plan
Checklist