prov/peer: Introducing peer "provider" with peer_cq to begin with #4

grom72 · 2022-12-02T13:37:16Z

include/ofi_peer.h file along with prov/peer directory defines space where peer-related common code is placed.
peer_cq is the first structure that has been defined. It is based on the coll_cq structure. coll provider uses peer_cq instead of removed coll_cq.

See man/fi_peer.3.md

Signed-off-by: Tomasz Gromadzki [email protected]

This change is

ldorau

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @grom72)

-- commits line 2 at r1:
introducing (small letter)

Code quote:

Introducing

-- commits line 5 at r1:
peer-related

Code quote:

peer related

-- commits line 9 at r1:
See man/fi_peer.3.md. - the commit message is in the plain-text format, not MD.

Code quote:

See [man/fi_peer.3.md](man/fi_peer.3.md)

Makefile.am line 89 at r1 (raw file):

	prov/util/src/cuda_ipc_monitor.c \
	prov/peer/src/peer_cq.c 	\
	prov/peer/src/peer.h 	        \

too many spaces or tabs (use only tabs, not spaces)

Code quote:

peer.h 	        \

include/ofi_peer.h line 2 at r1 (raw file):

/*
 * Copyright (c) 2019-2022 Intel Corporation, Inc.  All rights reserved.

Why not just 2022?

Code quote:

2019-2022

include/ofi_peer.h line 40 at r1 (raw file):

#include <ofi_list.h>
#include <ofi_atom.h>
#include <ofi_bitmask.h>

Are they really required here?

Code quote:

#include <ofi_atom.h>
#include <ofi_bitmask.h>

include/ofi_peer.h line 45 at r1 (raw file):

int ofi_peer_cq_open(struct fid_domain *domain, struct fi_cq_attr *attr,

Too many empty lines in between.

Code quote:

#include <ofi_util.h>



int ofi_peer_cq_open(struct fid_domain *domain, struct fi_cq_attr *attr,

include/ofi_peer.h line 52 at r1 (raw file):

			fi_addr_t src);

#endif // _OFI_PEER_H_

/* _OFI_PEER_H_ */ - // is a C++ comment

Code quote:

// _OFI_PEER_H_

prov/coll/src/coll_coll.c line 726 at r1 (raw file):

	ep = container_of(coll_op->ep, struct coll_ep, util_ep.ep_fid);

	ret = ofi_peer_cq_write(&ep->util_ep.tx_cq->cq_fid, coll_op->context,

redundant space at the end

Code quote:

,·

prov/peer/src/peer.h line 39 at r1 (raw file):

#if HAVE_CONFIG_H
#include <config.h>
#endif

What is it for?

Code quote:

#if HAVE_CONFIG_H
#include <config.h>
#endif

prov/peer/src/peer.h line 43 at r1 (raw file):

#include <ofi.h>
#include <ofi_util.h>

redundant empty line

prov/peer/src/peer_cq.c line 99 at r1 (raw file):

	ret = ofi_cq_init(provider, domain, attr, &cq->util_cq, 
		&ofi_cq_progress, NULL);

Doesn't it fit into one line?

Code quote:

	ret = ofi_cq_init(provider, domain, attr, &cq->util_cq,
		&ofi_cq_progress, NULL);

prov/peer/src/peer_cq.c line 122 at r1 (raw file):

ssize_t ofi_peer_cq_write(struct fid_cq *cq_fid, void *context, uint64_t flags,
			size_t len, void *buf, uint64_t data, uint64_t tag,
			fi_addr_t src)

Doesn't it fit into one line?

Code quote:

			size_t len, void *buf, uint64_t data, uint64_t tag,
			fi_addr_t src)

grom72

Reviewable status: 3 of 7 files reviewed, 13 unresolved discussions (waiting on @ldorau)

-- commits line 2 at r1: