Protocol changes for 1.21.50 #279
Conversation
|
hasFlag should probably be kept for compatibility |
|
It's a protocol update, we don't care about BC in the protocol. Every update requires breaking stuff anyway. |
|
CI is crying about something unspecified, pls run tests locally and see what the problem is |
| private UuidInterface $worldTemplateId; | ||
| private string $worldTemplateVersion; |
There was a problem hiding this comment.
These should be public as there are no get/setters
There was a problem hiding this comment.
You're right. If someone wants to make a PR of it, go for it. Else I'll sort it out tomorrow
There was a problem hiding this comment.
Yeah, the convention has been to keep fields public in older packets and only private them in newly added packets, to ensure the API is consistent within packets
There was a problem hiding this comment.
That being said I've never been super sure whether privating the fields was a good idea... what we really need more than anything else is #95
No description provided.