Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to async/await – spo sitedesign get until spo sitedesign task get, Closes #5106 #5128

Closed
wants to merge 4 commits into from
Closed

Refactor codebase to async/await – spo sitedesign get until spo sitedesign task get, Closes #5106 #5128

wants to merge 4 commits into from

Conversation

nicodecleyre
Copy link
Contributor

Closes #5106

@milanholemans
Copy link
Contributor

Thank you, we'll review it ASAP.

@Adam-it Adam-it self-assigned this Jul 21, 2023
Adam-it
Adam-it requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and still works ✅
only some small cosmetic tips and let's wait for other PR before we proceed so that we may improve even more

src/m365/spo/commands/sitedesign/sitedesign-get.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/sitedesign/sitedesign-get.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/sitedesign/sitedesign-remove.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft July 21, 2023 20:50
@nicodecleyre nicodecleyre force-pushed the Refactor-spo-sitedesign-get---spo-sitedesign-task-get branch from ba3be11 to 71c0d56 Compare September 1, 2023 17:29
@nicodecleyre nicodecleyre force-pushed the Refactor-spo-sitedesign-get---spo-sitedesign-task-get branch from 71c0d56 to 3a3e5ff Compare September 25, 2023 16:26
@nicodecleyre nicodecleyre marked this pull request as ready for review September 25, 2023 16:27
@Adam-it
Copy link
Member

Adam-it commented Sep 25, 2023

sorry @nicodecleyre for the hold up on this one 🙏. I will try to merge this first thing after the release

Adam-it
Adam-it approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally ✅
LGTM 👍

@Adam-it
Copy link
Member

Adam-it commented Oct 15, 2023

ready to merge 🚀

@Adam-it Adam-it added pr-merged hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 15, 2023
@Adam-it
Copy link
Member

Adam-it commented Oct 15, 2023

merged manually. Awesome work 👏

@Adam-it Adam-it closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor codebase to async/await – spo sitedesign get until spo sitedesign task get
3 participants
@nicodecleyre @milanholemans @Adam-it