-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes M365 group and connected site. Closes #5224 #5409
Conversation
Thank you @Saurabh7019, we'll try to review it ASAP! |
Could you resolve the merge conflicts please @Saurabh7019? |
5fdba36
to
82a27a2
Compare
Oh! I did git rebase main to resolve the conflicts and now all my changes are gone. :( Is there a way to recover the lost changes? @milanholemans |
Hi @Saurabh7019, is this the commit you are looking for? 5fdba36 If so, I suggest that you run:
Hopefully that will do it 🤞 |
Thank you for saving me a lot of time; I will update this PR tonight! |
82a27a2
to
d234b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. Let's do some adjustments before we continue
d234b7e
to
8efbd4d
Compare
I am unable to drop the 'Empty commit' that I added to re-trigger the build pipeline. For now, I will mark the PR as 'Ready for review' and attempt to remove the empty commit later. |
efcd136
to
8efbd4d
Compare
@waldekmastykarz I saw you already started this one. Do you want to continue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't done a full review, just noticed something we can improve.
8efbd4d
to
6a23631
Compare
I have removed the timeUtil and implemented the suggested change. Additionally, I have updated my previous email on the contributors list to reflect my current status as part of this PR. I hope that is okay. |
@Saurabh7019 sorry for the hold up. Do you think you could rebase before we proceed? |
6a23631
to
397e716
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally ✅
works nicely 👍
LGTM 👍
you rock 👏
ready to merge 🚀 |
merged manually. Awesome work 👏 |
Closes #5224