Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds command aad group remove #5435

Closed
wants to merge 2 commits into from

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #5426

@milanholemans
Copy link
Contributor

Thank you @MathijsVerbeeck, we'll try to review it ASAP.

@milanholemans milanholemans self-assigned this Aug 30, 2023
@milanholemans
Copy link
Contributor

milanholemans commented Aug 31, 2023

Hi @MathijsVerbeeck, could you update your PR to use ESM?

Major differences:

@milanholemans milanholemans marked this pull request as draft August 31, 2023 15:57
@milanholemans
Copy link
Contributor

Is this one ready to review @MathijsVerbeeck ?

@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review September 1, 2023 06:28
@MathijsVerbeeck
Copy link
Contributor Author

Is this one ready to review @MathijsVerbeeck ?

Sure thing!

Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MathijsVerbeeck!
Let's do a few tiny adjustments before we merge it.

src/m365/aad/commands/group/group-remove.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/aad/commands/group/group-remove.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft September 14, 2023 22:07
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review September 15, 2023 19:10
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add!

@milanholemans
Copy link
Contributor

Merged manually, thank you!

@MathijsVerbeeck MathijsVerbeeck deleted the aad-group-remove branch May 25, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: aad group remove
2 participants