Extends 'teams app remove' command with support for name option. Closes #5445 #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nanddeepn, we'll try to review it ASAP! |
nanddeepn
changed the title
nanddeepn
changed the title
martinlingstuyl
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Hi @nanddeepn, great work! I've got a few small comments before we merge this 👍
martinlingstuyl
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Looks great @nanddeepn, I'll merge it and fix a few last things while we're at it. 👏
| headers: { | ||
| accept: 'application/json;odata.metadata=none' | ||
| if (this.verbose) { | ||
| await logger.logToStderr(`Removing app with ID ${args.options.id}`); |
There was a problem hiding this comment.
Suggested change
| await logger.logToStderr(`Removing app with ID ${args.options.id}`); | |
| await logger.logToStderr(`Removing app with ID ${appId}`); |
| resultAsKeyValuePair[obj.id] = obj; | ||
| }); | ||
|
|
||
| return Cli.handleMultipleResultsFound(`Multiple Teams apps with name '${options.name}' found.`, resultAsKeyValuePair); |
There was a problem hiding this comment.
You should await this and type the result.
Suggested change
| return Cli.handleMultipleResultsFound(`Multiple Teams apps with name '${options.name}' found.`, resultAsKeyValuePair); | |
| const result = await Cli.handleMultipleResultsFound<{ id: string; }>(`Multiple Teams apps with name '${options.name}' found.`, resultAsKeyValuePair); | |
| return result.id; |
There was a problem hiding this comment.
oh, and we also missed a test case for this :-)
| if (options.id) { | ||
| return options.id; | ||
| } | ||
|
|
There was a problem hiding this comment.
We should add a verbose logging line here
|
Merged manually, thank you for the awesome work! 👏🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
teams app removecommand with support for specifying thenameoption. Closes #5445