Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spfx project upgrade for 1.18.0 #5501

Closed
wants to merge 1 commit into from

Conversation

milanholemans
Copy link
Contributor

Closes #5500

@milanholemans milanholemans changed the title Fixes spfx upgrade to 1.18.0 Fixes spfx project upgrade for 1.18.0 Sep 19, 2023
@milanholemans milanholemans marked this pull request as draft September 19, 2023 13:19
@milanholemans milanholemans force-pushed the fix-spfx-upgrade branch 2 times, most recently from a5ee3d2 to ed8f2b5 Compare September 19, 2023 19:32
@milanholemans milanholemans marked this pull request as ready for review September 19, 2023 19:49
@Adam-it Adam-it self-assigned this Sep 19, 2023
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. I checked this also on a clean SPFx 1.17.4

@Adam-it
Copy link
Member

Adam-it commented Sep 21, 2023

ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Sep 21, 2023

merged manually. You Rock 🤩

@Adam-it Adam-it closed this Sep 21, 2023
@milanholemans milanholemans deleted the fix-spfx-upgrade branch September 21, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: Unable to upgrade SPFx solution to v1.18.0
2 participants