Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances 'spo page set' command Closes #4840 #5502

Closed
wants to merge 1 commit into from

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented Sep 19, 2023

Enhances 'spo page set' with --content property Closes #4840

Linked Issue #4840

It adds the '--content' property to the 'spo page set' command, enabling the updating of the 'CanvasContent1' property of a page.

The PR includes changes done in PR #4846 and changes recommended by @martinlingstuyl.
Closes #4840

@mkm17
Copy link
Contributor Author

mkm17 commented Sep 19, 2023

Hi, @martinlingstuyl Please review the PR related to #4846.
Regarding the comment about the test, I believe we cannot use a spy in this case. Initially, request.post returns page properties, which means we need to return it using stub, and then it is used to save the content.

Consequently, I placed an assert at the end of the test, following the same approach used in 'page-section-add.spec.ts'

Let me know what you think.

I hope that I rebased everything correctly :)

@martinlingstuyl martinlingstuyl self-assigned this Sep 19, 2023
@martinlingstuyl
Copy link
Contributor

Thanks @mkm17! I'll review this ASAP! But probably not this week,due to the upcoming v7 release.

Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works like a glove @mkm17

@martinlingstuyl
Copy link
Contributor

Merged manually, thank you for the awesome work! 👏🎉

@mkm17 mkm17 deleted the issues/4840_spo_page_set_content branch October 7, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New flag: spo page set --content
3 participants